-
Notifications
You must be signed in to change notification settings - Fork 0
Activity page + popup #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Were you guys able to work on the modal part of it? Also make sure to merge in the main branch into this branch, and update any styling as needed |
Some of the imports were wrong when I pulled from the branch (mostly capitalization issues), so I had to change them to get it to run, but once it started working it looked good! Changes:profilePage.tsx:Original:
Changed To:
activityPage.tsx:Original:
Changed To:
|
I think git has issues with tracking changes to capitalization in file names lol I wanted to keep things consistent so I renamed the files to be capitalized, but ig that didn't get tracked correctly |
Just changed the imports back, we can fix the naming consistency issues later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fixes! Looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Tracking Info
Resolves #25
Changes
made the activity page look like figma design
made two components - one for each section button and one for the buttons
Testing
Tested locally with ios and android emulators
Confirmation of Change