Skip to content

Conversation

alexisvvega
Copy link

Tracking Info

Resolves #25

Changes

made the activity page look like figma design
made two components - one for each section button and one for the buttons

Testing

Tested locally with ios and android emulators

Confirmation of Change

Screenshot 2025-03-16 at 1 40 04 PM

@HarshGurnani
Copy link
Collaborator

Were you guys able to work on the modal part of it? Also make sure to merge in the main branch into this branch, and update any styling as needed

@yxli001 yxli001 changed the title Feat/veralex/activity page Activity page + popup Apr 22, 2025
@yxli001
Copy link
Contributor

yxli001 commented Apr 22, 2025

NEW CHANGES

  • Updated styles to match new designs
  • Rounded out the section header dropdown designs and functionality
  • Factored out the activity circle buttons to a separate component that supports clicked state (toggles the image, only the green button shows the clicked state for now because we don't have assets for the other ones) and decides which images to show based on color, status (in progress, completed, incomplete)
  • Added bottom popup component
    • Ideally i want to dismiss it when the backdrop is clicked but it's a little annoying and I don't think it's worth figuring out for now
    • For some reason the sliding animation is a little laggy because of the placement of the backdrop component, but again I don't think it's worth figuring out for now, maybe prod build will be more optimized anyways?

Screenshots

image image image

@HarshGurnani HarshGurnani requested review from JordanJunaidi, wllmwu and willcyber and removed request for wllmwu April 25, 2025 18:13
@JordanJunaidi
Copy link
Contributor

Some of the imports were wrong when I pulled from the branch (mostly capitalization issues), so I had to change them to get it to run, but once it started working it looked good!

Changes:

profilePage.tsx:

Original:

import Media from "@/assets/media.png";
import ButtonItem from "@/components/ProfileButton";

Changed To:

import Media from "@/assets/Media.png";
import ButtonItem from "@/components/profileButton";

activityPage.tsx:

Original:

import ActivityButton from "@/components/ActivityButton";
import SectionButton from "@/components/SectionButton";

Changed To:

import ActivityButton from "@/components/activityButton";
import SectionButton from "@/components/sectionButton";

@yxli001
Copy link
Contributor

yxli001 commented Apr 28, 2025

Some of the imports were wrong when I pulled from the branch (mostly capitalization issues), so I had to change them to get it to run, but once it started working it looked good!

Changes:

profilePage.tsx:

Original:

import Media from "@/assets/media.png";
import ButtonItem from "@/components/ProfileButton";

Changed To:

import Media from "@/assets/Media.png";
import ButtonItem from "@/components/profileButton";

activityPage.tsx:

Original:

import ActivityButton from "@/components/ActivityButton";
import SectionButton from "@/components/SectionButton";

Changed To:

import ActivityButton from "@/components/activityButton";
import SectionButton from "@/components/sectionButton";

I think git has issues with tracking changes to capitalization in file names lol

I wanted to keep things consistent so I renamed the files to be capitalized, but ig that didn't get tracked correctly

@yxli001
Copy link
Contributor

yxli001 commented Apr 28, 2025

Just changed the imports back, we can fix the naming consistency issues later.

Copy link
Member

@willcyber willcyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes! Looks good to me

Copy link
Contributor

@JordanJunaidi JordanJunaidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Activity Page - Home
5 participants